go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Add source and target endpoint as label for all client/server grpc metrics

Open rohsaini opened this issue 2 years ago • 2 comments

All the metrics currently reported by providers/prometheus have labels as "grpc_type", "grpc_service" and "grpc_method". But since, these do not include source and target endpoint information, it is not possible to get metrics for a particular grpc_service per connection level. These are more like aggregated metrics at grpc_service level.

So requesting to include these two additional labels also.

Example: grpc_server_msg_received_total{grpc_method="RegisterTimer",grpc_service="timergrpc.IpcService",grpc_type="unary"} 4

rohsaini avatar Sep 18 '23 09:09 rohsaini

I will leave this sort of decision to @bwplotka who is significantly more experience with metrics than I am.

johanbrandhorst avatar Sep 18 '23 21:09 johanbrandhorst

@bwplotka looking forward for your response.

rohsaini avatar Sep 22 '23 10:09 rohsaini