go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Published 20 hours ago • verified publisher icon grpc-ecosystem

fix zap logger example and add tests

Open theruziev opened this issue 2 years ago • 8 comments

  • [ ] I added CHANGELOG entry for this change.
  • [x] Change is not relevant to the end user.

Changes

  • Fix zap logging example
  • Add a test for zap example

Before: Screenshot 2023-05-08 at 16 16 49

After: Screenshot 2023-05-08 at 16 19 28

Verification

I added test for testing/verification

theruziev avatar May 08 '23 10:05 theruziev

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 08 '23 10:05 google-cla[bot]

I found discussion (#567) about adding tests for logging examples and I add it. @bwplotka cc

theruziev avatar May 08 '23 12:05 theruziev

Thanks for this and sorry for lag. Example was fixed, but I would love those tests! Do you mind rebasing?

bwplotka avatar Jun 12 '23 13:06 bwplotka

yep

theruziev avatar Jun 15 '23 17:06 theruziev

rebased, and returned examples function, maybe it's helpful to see how used it.

theruziev avatar Jun 16 '23 18:06 theruziev

ping @bwplotka @johanbrandhorst

theruziev avatar Jun 21 '23 06:06 theruziev

I returned interceptors to test files

theruziev avatar Jun 24 '23 09:06 theruziev

i work on it

theruziev avatar Jul 07 '23 17:07 theruziev