Yoan Blanc

Results 51 comments of Yoan Blanc

`end_of_line = consistent` sounds about right.

@florianb what is hard is to enforce it "locally" when [Git permits you][autocrlf] to use different line endings locally and remotely. E.g. on Windows, I'd like to have some `crlf`...

The idea sounds nice, I'd make it compatible with the [correlation-id plugin](https://docs.konghq.com/hub/kong-inc/correlation-id/) as they are likely to be used together.

`Compression` is used for PNG only: - https://github.com/jcupitt/libvips/blob/c90b8be0b8f5a428f7a8085635822ce621f2e3cd/libvips/foreign/pngsave.c#L284 - http://www.vips.ecs.soton.ac.uk/supported/current/doc/html/libvips/VipsForeignSave.html#vips-pngsave

we didn't experience any service disruption, only verbose logs.

Since going from 0.53 to 0.59 10 days ago, that error is gone from our logs. ![Screenshot 2022-09-16 at 14-33-24 Discover - OpenSearch Dashboards](https://user-images.githubusercontent.com/1388/190639619-fa8d533c-4c89-46d0-a8a5-2a56b42bd703.png) **EDIT** btw thanks for the fixes!!

How hard/breaking would it be to go with `consul/api.Agent.ServiceRegisterOpts` in the first call, meaning it would already contain the checks to be created, then perform the necessary cleanup. I've got...

@mstruebing / @tomtomsen do you mind testing https://github.com/editorconfig/editorconfig-core-go/pull/89?

There is a test case that shows what the issue is about https://github.com/greut/terraform-provider-vault-lazy-init

@benashz sure! We're running on [a fork](https://github.com/cyrilgdn/terraform-provider-vault/) for a couple of reasons already. Thanks for taking care of it and I'm really hoping we'll be able to drop the fork...