graphql-playground icon indicating copy to clipboard operation
graphql-playground copied to clipboard

Missing build/static directory in the latest release

Open dunglas opened this issue 4 years ago • 6 comments

This issue pertains to the following package(s):

  • [ ] GraphQL Playground - Electron App
  • [x] GraphQL Playground HTML
  • [ ] GraphQL Playground
  • [ ] GraphQL Playground Express Middleware
  • [ ] GraphQL Playground Hapi Middleware
  • [ ] GraphQL Playground Koa Middleware
  • [ ] GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

Mac OS.

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

n/a

What is the expected behavior?

Being able to use https://github.com/graphql/graphql-playground/blob/master/packages/graphql-playground-html/minimalWithoutCDN.html.

What is the actual behavior?

The /graphql-playground-react/build/static/ doesn't exist in the latest version. It is present in 1.7.26.

What steps may we take to reproduce the behavior?

Just download the latest package.

dunglas avatar Dec 01 '20 11:12 dunglas

If a maintainer is around, version 1.7.27 is a defective package as it's missing files, it should be pulled/republished.

Broken package: https://github.com/graphql/graphql-playground/releases/tag/graphql-playground-react%401.7.27

The GIT diff between the two, nothing particularly major: https://github.com/graphql/graphql-playground/compare/[email protected]@1.7.27

I'm not sure how the package is built, so can't find any build logs to look at but I suspect the build didn't output the files but the package was still published.

samkelleher avatar Feb 14 '21 12:02 samkelleher

https://unpkg.com/browse/[email protected]/

what is missing?

packages are built with yarn build, see package json

acao avatar Feb 14 '21 13:02 acao

Here is a duplicate issue: https://github.com/graphql/graphql-playground/issues/1310

The published npm package for graphql-playground-react is supposed to contain a directory /build/static/ which contains the ready built playground javascript/css files etc.

In 1.7.27 this entire directory is missing. > https://www.jsdelivr.com/package/npm/graphql-playground-react?path=build

In 1.7.26 and prior, the directory is present and correct. > https://www.jsdelivr.com/package/npm/graphql-playground-react?path=build%2Fstatic&version=1.7.26

The experience is that anyone using say the latest graphql-playground-html / graphql-playground-middleware-express for example sees a non-functional playground loader screen as neither the local package or the enabled-by-default CDN has the asset files.

It looks like something must have gone wrong during the CI process and the files weren't added, but I don't have access to build logs.

samkelleher avatar Feb 14 '21 13:02 samkelleher

ah. no publish from CI

react workspace needs to re-add this missing command then

acao avatar Feb 14 '21 13:02 acao

jason khurt from prisma offered to take over as maintainer again some time back. i wont have time to look at any of this for a few months

acao avatar Feb 14 '21 14:02 acao

@acao - Any updates on this? Or an ETA on the next release with the build/static directory? I work on a project that would benefit from one of the changes that was new to v1.7.27.

khneal avatar Jul 29 '21 15:07 khneal