dataloader icon indicating copy to clipboard operation
dataloader copied to clipboard

Published 20 hours ago • verified publisher icon graphql

CacheMap.get calls should await the promised value

Open gabidi opened this issue 2 years ago • 2 comments

https://github.com/graphql/dataloader/blob/015a94c8db0b4974838a312634c12a2c5eb3d056/src/index.js#L88-L97

Seems like this prevents the use of async calls to centralized caches in it's current implementation since the returned promise will be 'Truthy' even if it resolves with a cache miss (null, undefined).

Wondering if there is a design reason for this, or a PR is welcome ?

gabidi avatar Oct 31 '22 18:10 gabidi

@gabidi can you assign this to me if its still open?

vishalsingh2972 avatar Aug 09 '23 04:08 vishalsingh2972