pg-many-to-many icon indicating copy to clipboard operation
pg-many-to-many copied to clipboard

Published 20 hours ago • verified publisher icon graphile-contrib

Junction filters

Open singingwolfboy opened this issue 6 years ago • 2 comments

This implements basic junction table filtering for many-to-many connections, in the same way that PgConnectionArgCondition does. By default, this filtering arg is named junctionCondition, and is managed separately from the condition arg. However, if the developer adds a @manyToManyCombinedConditionArg smart comment to the constraint, the filters for the junction table and the right table will be combined in the condition arg (and duplicated filterable columns will result in an error).

This pull request depends on #43, and is rebased on top of it.

singingwolfboy avatar Nov 05 '19 12:11 singingwolfboy

(v4.5.0-rc.0 is now out.)

benjie avatar Nov 13 '19 12:11 benjie

This is great, thanks! I'm hesitating to merge only because filtering functionality tends to be a slippery slope (as I know all too well :wink: ). I'm also not sure it should be exposed by default.. on some of my own projects I've excluded the core PgConnectionArgCondition plugin and replaced it with the filter plugin, and I would probably exclude junctionCondition as well. How do you feel about maintaining this separately?

mattbretl avatar Feb 13 '20 07:02 mattbretl