Grant Timmerman

Results 165 comments of Grant Timmerman

I believe this is WAI as reported. If you're facing a real issue writing notebooks in RTL languages, please state the expected behavior and we can change the behavior to...

Are there more details to the issue with printing? --- We can pretty easily remove the **nav header** with CSS when printing with some CSS: ```css @media print { ......

I can't repro this issue either.

I don't know if it make sense to pin/unpin in this case. The logic for showing this pin is: `editable && hasOutput && !readOnly` Making this more generous and not...

It looks like this action assumes that the jest config is a `json` file (ours is not), and so it improperly gets the coverage threshold config value. https://github.com/ArtiomTr/jest-coverage-report-action/blob/952a05968ad9e0b4ab2ab221a8d7d72e621aec51/src/utils/getNormalThreshold.ts#L10

Hi @ArtiomTr , do you know the answer to this? Would you say that this default config is a bug? It would be nice if the default 0 so action...

Thanks. I don't think we're going to use this Action for our use-case. For this issue, was just looking for an option to disable the column or use our config.

Yeah that resulting UI would be perfect @ArtiomTr! I think the 0.1 threshold sounds reasonable, users don't get much info from that percentage change, but may get some useful info...

I'll try to get to a PR for this, thanks!