gramine icon indicating copy to clipboard operation
gramine copied to clipboard
verified publisher icon gramineproject

mmap(2) tests fail on SGX

Open oshogbo opened this issue 3 years ago • 1 comments

Description of the problem

As pointed out by @dimakuv, the test_204_copy_dir_mmap_whole test from the test_fs.py is marked as failing with the SGX. We would like to debug why this is happening.

oshogbo avatar Jun 20 '22 10:06 oshogbo

I can look into this.

oshogbo avatar Jun 20 '22 10:06 oshogbo

@oshogbo Found one more issue that you wanted to take a look at :)

dimakuv avatar Mar 09 '23 14:03 dimakuv

It seems that we do not implement mmap(PROT_WRITE) which is used by this test. In my opinion, this test was added just to have the whole coverage for different flags for mmap - so it doesn't seem to be invalid.

At this point, we don't have workloads with this routine. So I propose to close this PR.

oshogbo avatar Mar 24 '23 11:03 oshogbo

@oshogbo: Could you add a short comment there explaining why this test is disabled on SGX? Otherwise we'll have this very discussion again in a year :)

mkow avatar Mar 27 '23 01:03 mkow

@mkow Sorry I didn't notice you have reopened this issue. I have created PR.

oshogbo avatar Apr 25 '23 16:04 oshogbo