Graham Christensen
Graham Christensen
I don't think it is in a single script, but dispersed around, unfortunately.
I see there is a reproducer from @limeytexan at https://github.com/limeytexan/NixOS-patchelf-issue-146. I've uploaded a .tar.gz of the source and the patchelf'd and unpatchelf'd build results for posterity. Log: ``` [nix-shell:~/projects/github.com/limeytexan/NixOS-patchelf-issue-146]$ nix-build...
fwiw I've merged the .12 update, because they're usually worth updating to. This issue is still one. The patches I madee are: master: 6c17ad677c4970c87e8562574ea7e6fbf12b0813 release-16.09: 4368adb6ac631b3bdbb071e96dfc545c1f8f92e1 release-17.03: beab3073c9caec3e6b67558efc6111bb68c7a2ab
We have 1.2.19 across the board, I'm not sure if we're vulnerable.
fwiw I've merged the .12 update, because they're usually worth updating to. This issue is still one. The patches I madee are: master: 6c17ad677c4970c87e8562574ea7e6fbf12b0813 release-16.09: 4368adb6ac631b3bdbb071e96dfc545c1f8f92e1 release-17.03: beab3073c9caec3e6b67558efc6111bb68c7a2ab
@7c6f434c If this was turned on per-builder, would it make all builders an attractive target? ie: if only the AWS machines were able to produce binaries, would you be uncomfortable...
nodejs specifies `pos` to stdenv which apparently helps magically set meta.position https://github.com/NixOS/nixpkgs/blob/ba1a181a88c8c8dd6e7038011b0a6241e2243b45/pkgs/stdenv/generic/make-derivation.nix#L65
this `pos` override is only used by haskell and nodejs https://search.nix.gsc.io/?q=pos%20%3D&i=nope&files=.*%5C.nix%24&repos=NixOS-nixpkgs but could be very helpful.
lgtm, but I strongly prefer the enum and impl From method of handling errors, the implementations are easy and a bit boilerplate heavy, but easy to understand and extend. I'd...
Right now we have three mac builders. I think that is a good idea, @7c6f434c, and solves the issue around darwin not having adequate sandboxing for this use case. I...