tempo-operator icon indicating copy to clipboard operation
tempo-operator copied to clipboard

Published 20 hours ago • verified publisher icon grafana

Make log level configurable

Open pavolloffay opened this issue 2 years ago • 4 comments

The log level is set as CMD argument. It would be helpful to expose it in the CRD e.g. in the observability spec https://github.com/grafana/tempo-operator/blob/754a9adb68bb8261f1c0eaac3ec8e9e6a8d8730d/apis/tempo/v1alpha1/tempostack_types.go#L122

pavolloffay avatar Sep 04 '23 12:09 pavolloffay

Related PR to make it easier to change the log level for ad-hoc debug sessions using unmanaged mode: https://github.com/grafana/tempo-operator/pull/550

andreasgerstmayr avatar Sep 04 '23 13:09 andreasgerstmayr

Guys, can I get this one?

yuriolisa avatar Feb 06 '24 15:02 yuriolisa

Guys, can I get this one?

We have multiple components (operator, tempo, tempoQuery, tempoGateway, tempoGatewayOpa) - should we have one setting to change the log level for all components? One setting per component?

Currently you can switch the Tempo CR to Unmanaged mode, and edit the -log.level CLI argument of the deployment/statefulset you want to debug. imho this is an efficient way to debug the instance (e.g. you can also change the command of the pod, etc.), what do you think? Is an additional field in the CR required?

andreasgerstmayr avatar Feb 06 '24 16:02 andreasgerstmayr

@andreasgerstmayr, I believe we could keep both, the CLI parameters and add a new logLevel to the ObservabilitySpec which will work as a global loglevel as well.

yuriolisa avatar Feb 12 '24 11:02 yuriolisa