synthetic-monitoring-agent icon indicating copy to clipboard operation
synthetic-monitoring-agent copied to clipboard

Fix: make label names uniform

Open mem opened this issue 1 year ago • 2 comments

Our use of labels names in logs and metrics is not uniform and this is causing a lot of pain.

We have foo_id, fooID and other variations.

Pick one.

It's fooId from now on.

It's going to be painful to change everywhere else to match this, but it's better than dealing with the existing pain.

mem avatar Jan 31 '24 18:01 mem

So from now on we use camelCase for log labels, but we should keep using snake_case for prom labels, right?

nadiamoe avatar Mar 07 '24 11:03 nadiamoe

So from now on we use camelCase for log labels, but we should keep using snake_case for prom labels, right?

I didn't think that far, but sounds reasonable.

Basically I looked at what would introduce the least changes, and camel case for log labels won.

mem avatar Mar 07 '24 16:03 mem