k6
k6 copied to clipboard
grafana
chore: Move the validation func from helpers to ramping vus
What?
I had it on a draft for a long time and I think is still worth considering the low effort. It amends what we did on https://github.com/grafana/k6/pull/3470 moving the function closer to where they are used.
Why?
The logic implemented is specific for ramping-vus and it shouldn't be reusable for other executors. Then it's better to have it in the specific file instead of the generic helpers.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.58%. Comparing base (
b217bbf) to head (c4d7837).
:exclamation: Current head c4d7837 differs from pull request most recent head b0da697. Consider uploading reports for the commit b0da697 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #3616 +/- ##
=======================================
Coverage 73.57% 73.58%
=======================================
Files 277 277
Lines 20244 20244
=======================================
+ Hits 14895 14896 +1
+ Misses 4401 4400 -1
Partials 948 948
| Flag | Coverage Δ | |
|---|---|---|
| macos | ? |
|
| ubuntu | 73.49% <100.00%> (-0.03%) |
:arrow_down: |
| windows | 73.43% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
