before-after-hook icon indicating copy to clipboard operation
before-after-hook copied to clipboard

package.json is blocking renovate from running

Open DasBen opened this issue 2 years ago • 2 comments

image

I've been updating an GitHub Action I was working on and found this problem through my Renovate Dashboard, which is completly blocking Renovate from updating my dependencies:

Repository problems
These problems occurred while renovating this repository.

Source: node_modules/before-after-hook/package.json

Reason: Nested package.json must not contain Renovate configuration. Please use packageRules with matchFileNames in your main config instead.

Message: undefined

Looks like the reason is this in the "package.json":

  "renovate": {
    "extends": [
      "github>gr2m/.github"
    ]
  }

I tried fixing it with excluding the "package.json" through renovate, but sadly this one did not work.

  ...
  "packageRules": [
    {
      "matchFileNames": ["node_modules/before-after-hook/package.json"],
      "enabled": false
    }
  ]

Can I fix this on my end or is this an error on the published package?

DasBen avatar Dec 28 '23 08:12 DasBen

Any chance this is getting fixed?

DasBen avatar Jan 11 '24 12:01 DasBen

Odd I didn't run into this myself, and this module is used by octokit which is widely used. Please feel free to send a pull request, but I do want to keep inheriting from https://github.com/gr2m/.github/blob/main/renovate.json

gr2m avatar Jan 14 '24 18:01 gr2m