gpodder icon indicating copy to clipboard operation
gpodder copied to clipboard

Include only the required GTK icons in the Windows and Mac versions

Open anewuser opened this issue 3 years ago • 5 comments

gPodder for Windows currently ships with the whole Adwaita icon set (thousands of files). If possible, this set should be trimmed to only the icons that the application actually uses to make installing/unzipping/updating/backing up/moving gPodder to another folder much faster.

anewuser avatar Jul 19 '22 02:07 anewuser

That is easier said than done. There is no way to tell what icons gpodder uses. Someone could visually look at the UI and make a list but then we would need to update that list everytime icons are changed, added or removed. No one will remember to do that and the Windows and Mac builds would be missing icons.

After the release, I'd like to change all icons to their "symbolic" variant and that would make it possible to automate the process by scanning all files for "*-symbolic".

I don't know if Windows and Mac users can install third-party extensions, but this would cause missing icons if the extensions use any not installed by gpodder.

auouymous avatar Jul 19 '22 02:07 auouymous

There is no way to tell what icons gpodder uses.

This can actually be done by just monitoring the process:

gpodder

However, if you can automate it, that's a better idea.

anewuser avatar Jul 19 '22 11:07 anewuser

On gPodder 3.11.0 on Windows, when enabling the toolbar (Ctrl+T), the preferences icon is missing:

Screenshot 2022-09-23 074005

This seems to be preferences-desktop:

<object class="GtkToolButton" id="toolPreferences">
  <property name="visible">True</property>
  <property name="can-focus">False</property>
  <property name="action-name">app.preferences</property>
  <property name="label" translatable="yes">Preferences</property>
  <property name="icon-name">preferences-desktop</property>
</object>

thp avatar Sep 23 '22 07:09 thp

That icon doesn't exist for 64x64 and larger icon sizes, and it appears gtk doesn't fallback to smaller icons. Maybe we should switch to preferences-other-symbolic.

auouymous avatar Sep 23 '22 09:09 auouymous

#1404 makes this switch and changes the other toolbar icons to symbolic to match.

auouymous avatar Sep 23 '22 09:09 auouymous