goto40

Results 94 comments of goto40

Thank you for the comments. I updated the wiki.

Sounds very interesting! Thank you for your interest and your contribution. We need the expertise of @igordejanovic and @danixeee to help you organize the first steps of your PR or...

This would solve one part, define a RREL depending on the type. But the format of the reference needs still to be repeated... How about allowing to define a default...

Do you mean something like Javadoc for grammars...? The referenced paper seems to describe another approach.

Great! I need some time to look at it. Quick idea: Showing also the type of the rule (e.g. abstract) would greatly improve the overall compréhension of a grammar. You...

> But is the static assertion fires, the dynamic will as well no? No. In the described cases (unit test), the problematic code is never called (protected by an `if`),...

in `xview.hpp` https://github.com/xtensor-stack/xtensor/blob/f3c11b2d810159e7063daddeaa0764f4006e5a73/include/xtensor/xview.hpp#L1572 ```c++ template template inline auto xview::access(Arg arg, Args... args) -> reference { if (sizeof...(Args) >= this->dimension()) //

See also my comments above in this PR. There I try to explain my observations.

Good point. I will also need more time to analyze... Please comment, as soon you have new insights!

Note: have you seen the comments with `label1` and `label2`? Do you have an explanation why we have this difference: why we take `integral_count` and `newaxis_count` in account for one...