mux

mux copied to clipboard

Summary of Changes

1. Added golangci-lint linter
2. Makefile for "lint" and "test"
3. Updated code as per issues raised by linter

@elithrarm, need your inputs. I believe we can close this PR for the below reasons:

1. We could achieve the same results in a better way. Github actions supports golangci-lint. I'm sharing few examples how the config will look like if we go ahead with Github actions. https://github.com/golangci/golangci-lint/blob/master/.github/workflows/pr.yml https://github.com/golangci/golangci-lint-action#how-to-use

2. For contributors we can configure pre-commit hook as a part of project. https://pre-commit.com/hooks.html

Looking forward to your inputs.

If we go ahead with the new proposed approach, we will be introducing new files:

• .github/WORFLOW/pr.yml
• .pre-commit-config.yml

This has been added during the transition