handlers

handlers copied to clipboard

Fixes #234

Summary of Changes

1. Upgrade httpsnoop

Can you please fix the CI pipeline failure issue? I will also take a look if updating the httpsnoop version is a breaking change or not.

Thank you

Can you please fix the CI pipeline failure issue?

Here you go https://github.com/gorilla/handlers/pull/236

Hi @malt3, oops I should write it briefly. You need to fix the pipeline in the current PR. Here is the required diff to understand file changes better

diff --git a/handlers_go18_test.go b/handlers_go18_test.go
index d8e6321..ec227cc 100644
--- a/handlers_go18_test.go
+++ b/handlers_go18_test.go
@@ -1,3 +1,4 @@
+//go:build go1.8
 // +build go1.8
 
 package handlers

If you find it difficult to understand. Save the above diff output in a file let's say patch.txt and apply the patch git apply patch.txt. Add a commit message and push the changes. You can close other PR #236

Indeed this is not a breaking change, we can request the actual maintainer to merge this PR.

It is very weird for me to resolve existing problems in this unrelated PR. I also question wether you are an actual maintainer of this project. Maintainers can edit the PR so feel free to apply the exact patch you proposed to me yourself.

It is very weird for me to resolve existing problems in this unrelated PR.

I agree but keeping in mind that the original maintainer is quite busy and it's better to accommodate that minor change in the same PR.

I also question whether you are an actual maintainer of this project. Maintainers can edit the PR so feel free to apply the exact patch you proposed to me yourself.

No, I'm not the actual maintainer that's why I'm requesting you. 🙂

I see. :smile:

Sorry for making this complicated initially.

Completed via https://github.com/gorilla/handlers/pull/241