handlers icon indicating copy to clipboard operation
handlers copied to clipboard

Fix whitespace handling in `X-Forwarded-For` header parsing

Open adam-p opened this issue 3 years ago • 3 comments

Fixes #227

Summary of Changes

  1. Split X-Forwarded-For using space rather than comma-space.
  2. Trim whitespace from resulting value.
  3. Add tests. (Including for Forwarded parsing, which didn't have this problem.)

adam-p avatar Mar 27 '22 18:03 adam-p

I don't know how to interpret the CircleCI failure.

adam-p avatar Mar 27 '22 18:03 adam-p

@adam-p thank you for working on this. In order to fix the pipeline issue. You need to add line //go:build go1.8 at the top of the file handlers_go18_test.go in the project.

amustaque97 avatar Jun 01 '22 20:06 amustaque97

@adam-p If you would resolve the conflict with this pull request we can get it reviewed and merged. Thanks!

coreydaley avatar Aug 17 '23 15:08 coreydaley