GDLauncher icon indicating copy to clipboard operation
GDLauncher copied to clipboard

Add technic modpacks

Open KundaPanda opened this issue 3 years ago • 5 comments

Purpose

This PR adds support for technicpack (both legacy and solder API) modpacks. I completely forgot about the original PR (#1136) since it took a while to review so now I'm creating a new one. Linked issue: #109

Approach

I have added API calls to technic and solder for fetching modpack information and created modpack views + actions for solder and technic modpacks. Unfortunately, legacy API only supports the latest version and some releases do not any timestamps to use as release dates.

Open Questions and Pre-Merge TODOs

  • [ ] Is there a better way for handling one-zip modpacks?
  • [ ] Most of the time, no information about required forge versions is returned, should this be extracted from version.json inside modpack.jar or left at the latest fml version?
  • [ ] Older modpacks (tekkit, etc.) fail to install due to missing minecraftforge libraries. This is also described in #1398.

Learning

  • Used API documentation for Technic and Solder
  • Sniffed a working build version for the API from Technic Launcher, since the update endpoint returns outdated data.

KundaPanda avatar Jul 11 '22 22:07 KundaPanda

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 11 '22 22:07 CLAassistant

I also tried to launch tekkit and Hexxit II without success, for the first one I get the following error:

image

for the hexxit II:

image

Ladvace avatar Aug 09 '22 09:08 Ladvace

I also tried to launch tekkit and Hexxit II without success, for the first one I get the following error:

image

for the hexxit II:

image

The Hexxit II unable to start can be fixed by choosing the symlink option, I have already detailed this in #1133.

In the case of Tekkit, this is caused by some Minecraft libraries not being available as described in the Open Questions and Pre-Merge TODOs section and issue #1398.

KundaPanda avatar Aug 09 '22 16:08 KundaPanda

I also tried to launch tekkit and Hexxit II without success, for the first one I get the following error: image for the hexxit II: image

The Hexxit II unable to start can be fixed by choosing the symlink option, I have already detailed this in #1133.

In the case of Tekkit, this is caused by some Minecraft libraries not being available as described in the Open Questions and Pre-Merge TODOs section and issue #1398.

I would open some kind o modals to explain that in case they fail then, or when you start the instance

Ladvace avatar Aug 10 '22 06:08 Ladvace

I also tried to launch tekkit and Hexxit II without success, for the first one I get the following error: image for the hexxit II: image

The Hexxit II unable to start can be fixed by choosing the symlink option, I have already detailed this in #1133.

In the case of Tekkit, this is caused by some Minecraft libraries not being available as described in the Open Questions and Pre-Merge TODOs section and issue #1398.

I would open some kind o modals to explain that in case they fail then, or when you start the instance

I completely agree with this, but shouldn't such feature be implemented in another PR? I feel like creating these kinds of pull requests that change a lot of functionality can lead to unexpected issues and a potential lack of clear regression.

I would be more than happy to fix both issues were they specific to technic modpacks, but both of them occur for other modpacks as well (I will provide a detailed example later).

I can, however, mark the default modpacks as either requiring the symlink option to be enabled or completely broken due to missing dependencies, since it does not affect other functionality.

KundaPanda avatar Aug 10 '22 14:08 KundaPanda

Stale. Please reopen when the issues are fixed.

Eskaan avatar Jan 20 '23 08:01 Eskaan

These issues are the same issues as #1459

furtabs avatar Jan 22 '23 22:01 furtabs