OpenGoPro icon indicating copy to clipboard operation
OpenGoPro copied to clipboard

timeout, retries ignored in _find_device

Open solderdev opened this issue 3 years ago • 0 comments

Hi!

This code:

gopro = GoPro(target=f".*1234") gopro.open(timeout=5, retries=3)`

ignores the provided timeout and retries parameters in function: open_gopro/ble/client.py:100 --> self._find_device()

Call stack: open, client.py:100 _open_ble, gopro.py:528 open, gopro.py:363

This causes _find_device to spend 30 retries with 5s (default parameters).

Fix: hand parameters "timeout" and "retries" down to _find_device in client.py:100.

Thank you, P

solderdev avatar Sep 27 '22 12:09 solderdev