chore: reduce circular generation
In this PR:
- Only generate the libraries if the last commit in the current branch has changed
generation_config.yaml. - Restore trigger in
.github/workflows/update_googleapis_commit.yamland.github/workflows/hermetic_library_generation.yaml - Remove
.github/workflows/generate-from-configuration.yaml
Example pull request: https://github.com/JoeWang1127/google-cloud-java/pull/29, the hermetic_library_generation workflow triggered twice in this PR, but the second time exited early.
Not sure if it matters, Verify GAPIC client library generation is failing, please take a look.
Not sure if it matters,
Verify GAPIC client library generationis failing, please take a look.
I don't think it's related to this pull request. It used new-client.py.
We need to update the version in the template.
diff --git a/pom.xml b/pom.xml
index 3a[8](https://github.com/googleapis/google-cloud-java/actions/runs/8898222544/job/24434897316?pr=10729#step:5:9)11bd99..aba7f9fe2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,7 +207,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
- <version>3.1.2</version>
+ <version>3.1.1</version>
<configuration>
<skip>true</skip>
</configuration>
Created https://github.com/googleapis/sdk-platform-java/pull/2704
We need to update the version in the template.
diff --git a/pom.xml b/pom.xml index 3a[8](https://github.com/googleapis/google-cloud-java/actions/runs/8898222544/job/24434897316?pr=10729#step:5:9)11bd99..aba7f9fe2 100644 --- a/pom.xml +++ b/pom.xml @@ -207,7 +207,7 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-deploy-plugin</artifactId> - <version>3.1.2</version> + <version>3.1.1</version> <configuration> <skip>true</skip> </configuration>
I think we should either
- Disable the renovate bot config for any Maven dependencies managed in our template.
- Or extend google-cloud-java's root pom from java-share-config so that we don't have to manage the versions of
maven-deploy-pluginandnexus-staging-maven-plugin. WDYT @suztomo ?
I think we should either
- Disable the renovate bot config for any Maven dependencies managed in our template.
- Or extend google-cloud-java's root pom from java-share-config so that we don't have to manage the versions of
maven-deploy-pluginandnexus-staging-maven-plugin. WDYT @suztomo ?
For me, I prefer the 2nd option.
However, I don't think this issue will block merging this PR as the sdk-platform-java update will fix this issue temporarily and we can implement a fix later.