google-cloud-cpp

google-cloud-cpp copied to clipboard

…nstead.

---

This change is 

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

/gcbrun

Google Cloud Build Logs For commit: da4c213d1cde2d68937fde1a09ac6718c46ea0f6

• Public Access Build Logs
• Cloud Build Console (requires auth)
• Kokoro Logs (requires auth)

:information_source: NOTE: Kokoro logs are linked from "Details" below.

Thanks for the PR! I have started the CI builds, let's see how they go.

I can't see the failures. What version of Bazel does your project use? "use_cpp_toolchains" was added in a recent version.

I can't see the failures.

There is a link to public logs in a previous comment:

https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/9466/da4c213d1cde2d68937fde1a09ac6718c46ea0f6/index.html

What version of Bazel does your project use? "use_cpp_toolchains" was added in a recent version.

That would do it. We test with Bazel 5.2.0 and Bazel 4.0.0

Looks like the issue is actually rules_cc, which hasn't yet released the changes with use_cpp_toolchain. If I can get them to do a new release, will that be something that we can update in this PR?

Looks like the issue is actually rules_cc, which hasn't yet released the changes with use_cpp_toolchain. If I can get them to do a new release, will that be something that we can update in this PR?

Sure, though I suspect the robots would pick such a change and send us a PR too.

@katre have you heard back? If not, maybe we should close this PR until we have some clarity?

They were cutting a release yesterday but ran into trouble. Can this stay open until early next week?

Can this stay open until early next week?

Sure, no problem. I suspect you will need to rebase, we have changed the builds since you started the PR.

That's fine, once the rules_cc release is done I'll handle that.

In case you missed it, the robots sent us #9572 to update rules_cc. It failed with the oldest version of Bazel we support (4.2):

https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/9572/f8b726915a67c676f6d414c672abf097e65c4719/fedora-36-bazel-oldest/log-f6435d74-72db-403c-b8f4-0313c1e267e2.txt

We will drop support for Bazel 4.2 around the time Bazel 6.0 is released. Maybe we can try all these updates at that time?