google-auth-library-python icon indicating copy to clipboard operation
google-auth-library-python copied to clipboard

test issues

Open 0-wiz-0 opened this issue 1 year ago • 2 comments

I'm packaging for pkgsrc. When running the self tests, there are some problems.

  1. Test dependencies are not documented
  2. There is a problem with using AsyncMock.
ImportError while importing test module '/scratch/security/py-google-auth/work/google_auth-2.35.0/tests/transport/aio/test_aiohttp.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/pkg/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/transport/aio/test_aiohttp.py:18: in <module>
    from mock import AsyncMock, Mock, patch
E   ImportError: cannot import name 'AsyncMock' from 'mock' (/usr/pkg/lib/python3.12/site-packages/mock/__init__.py)

Environment details

  • OS: NetBSD/10.99.12
  • Python version: Python 3.12.6
  • pip version: n/a
  • google-auth version: 2.35.0

Steps to reproduce

Run the self tests, see problems with missing dependencies. Most can be fixed by just adding them, but I need a patch for the asyncmock issue:

--- tests/transport/aio/test_aiohttp.py.orig    2024-09-22 16:01:57.881298857 +0000
+++ tests/transport/aio/test_aiohttp.py
@@ -15,7 +15,7 @@
 import asyncio

 from aioresponses import aioresponses  # type: ignore
-from mock import AsyncMock, Mock, patch
+from unittest.mock import AsyncMock, Mock, patch
 import pytest  # type: ignore
 import pytest_asyncio  # type: ignore

The full list of test dependencies seems to be (as of 2.35.0):

aiohttp
requests
pyu2f
aioresponses
flask
freezegun
mock
responses
test-asyncio
test-localserver

0-wiz-0 avatar Sep 22 '24 16:09 0-wiz-0