gapic-generator-python icon indicating copy to clipboard operation
gapic-generator-python copied to clipboard
verified publisher icon googleapis

Catch warnings in flattened tests for deprecated fields in gapic-generator-python

Open mukund-ananthu opened this issue 2 years ago • 4 comments

  1. Currently, the warnings are bubbling up and blocking submission of PRs like: https://github.com/googleapis/python-pubsub/pull/1064
  2. A temporary silencing of the warning is being added in https://github.com/googleapis/python-pubsub/blob/main/pytest.ini as part of https://github.com/googleapis/python-pubsub/pull/1066. This silencing of warning is to be removed once warnings are no longer bubbled up from the flattened tests.

mukund-ananthu avatar Jan 29 '24 20:01 mukund-ananthu

cc: @parthea

mukund-ananthu avatar Jan 29 '24 20:01 mukund-ananthu

Fixed as part of https://github.com/googleapis/python-pubsub/pull/1066

mukund-ananthu avatar Feb 07 '24 17:02 mukund-ananthu

@mukund-ananthu Please could you file an issue in gapic-generator-python for the long term fix to improve the generated unit tests ? The underlying issue is that deprecation warnings should not bubble up in flattened tests for deprecated fields.

parthea avatar Feb 07 '24 17:02 parthea

Please could you file an issue in gapic-generator-python for the long term fix to improve the generated unit tests

@parthea Sure. Created https://github.com/googleapis/gapic-generator-python/issues/1937

mukund-ananthu avatar Feb 07 '24 18:02 mukund-ananthu