api-linter

api-linter copied to clipboard

While building a bazel test rule for api-linter, encountered this panic: ```go panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x130f0e7] goroutine...

pcj

https://linter.aip.dev/133/request-parent-required will show a warning whenever there is no `parent` field. AIP-133 specifically mentions: `A parent field must be included unless the resource being created is a top-level resource` (since...

bMacSwigg

Thanks for stopping by to let us know something could be better! **PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/)...

slaweg

aip0124: why do referenced resources need to be in the same package?

8

The implemented rule for AIP124 [enforces](https://github.com/googleapis/api-linter/blob/master/rules/aip0124/valid_reference.go#L91) that if a resource is referenced using `google.api.resource_reference` annotation, the referenced resource must be in the same package as the one referencing it. Otherwise,...

ialcor-zz

Hoisting fields for BatchCreate* requests blocked by linter

5

The [docs for batch creation](https://google.aip.dev/233#request-message) state: Other fields may be "hoisted" from the standard Create request, which means that the field can be set at either the batch level or...

adsouza

Please add the necessary include to https://linter.aip.dev/203/optional

4

The page at https://linter.aip.dev/203/optional should have the following for the sample code: // Correct. import "google/api/field_behavior.proto"; message Book { string name = 1; // The foreword for the book. string...

Alasdair-Mackintosh

Some examples for fields: - `string github_repo = 1` (not `git_hub_repo`) - `string stackoverflow_username = 1` (not `stack_overflow_username`) - `string bigquery_table = 1` (not `big_query_table`) And fields in camel-case: -...

jgeewax

Move lint rules to a FileDescriptorSet-based library

9

This is more to start a discussion than anything concrete, not sure if you'd be interested in this at all. So a few points: - Protoreflect is a magical library,...

bufdev

YAML output issues

6

Similar to #306, using same commit of both api-linter and googleapis/googleapis. Issues: - Arrays elements printed for files with no problems. - I think this invalid YAML but might be...

bufdev

Unwritten cloud AIP: Non-project resources

1

We still need a cloud AIP for this one. Old lint rule: https://g3doc.corp.google.com/google/api/tools/linter/g3doc/rules/non-project-resources.md?cl=head

robcapo