googleads-mobile-flutter

googleads-mobile-flutter copied to clipboard

Plugin Version

3.0.0

Steps to Reproduce

Just run a native ad on ios and see that it renders with a border around it.

Expected results: The ad renders without borders.

Actual results: The ad renders with borders. See image:

Hi @naamapps,

The borders you are noticing are working as intended. I have labeled this case as a feature request and escalated to the greater team.

Hey @malandr2, Thanks for your quick comment. Please explain why is this the intended behavior, it seems like a bug to me. The borders are really distracting from the main content of the app.

Also why did you close the issue if it is not resolved? Shouldn't it be open until it's resolved?

Hey @naamapps, ticket is re-opened. Will be closed once resolved by engineering.

The border is part of the UI and it is black by default. @jjliu15 feature request would be to allow customization of the border color.

Got it. Looking forward to this new feature to control the border color. Also if it's possible, maybe add an option to control the border radius? Just suggesting a few customizations. Thanks

I also see this issue on Android as well. Updating labels corresponding to this. Verified on plugin versions: google_mobile_ads: ^3.0.0

Demo Android

Flutter plugin - Android	Android native example

https://github.com/googleads/googleads-mobile-flutter/issues/842#issuecomment-1709401591

CHECK THIS

@ravitaak per your comment, we cannot recommend modifying the plugin code itself. I've re-raised this issue with the engineering team for visibility's sake. Thanks.

Thanks for your response @malandr2, However every issue only seems for visibility's sake. Why is there no actual work being done to resolve those critical issues?

This package looks abandoned and forgotten. Please take this package seriously, and not like a side project.

Hey @naamapps, this specific issue isn't as high of a priority fix for the team compared to the others. Rest assured work is being done to address the larger issues in the list as well as implementing new features (those do not have any associated GitHub tracker).

Commenting for issue visibility.

The current state of this feature bothers me a lot as it makes use cases for the native ads very limited. E.g. I want the ads to match the dark theme of my application. I can make the inside of the ad dark, but the white, eye-burning border stays there no matter what:

@bcyran, ACK. Thanks for your feedback.

@malandr2 When will it be updated? I am still waiting for the custom design features.

Bump! Native ads have more potential for revenue growth than any other ad type, but it all depends on their ability to mesh well with the whole app's style. Introducing basic customization features shouldn't detract too much from other issues :(

Hi there!,

Some news about it?

Thanks,

Hi,

Any new about this? It doesn't make sense to use this kind of ad if it's not fully customizable with the UI

Thanks

I managed to set the borders transparent by adding these two lines in my android/app/src/main/res/values/styles.xml:

For IOS Comment following line

ios/Classes/NativeTemplates/GoogleAdsMobileIosNativeTemplates/GADTTemplateView.m inside the package file

This helps me change the border and color.

- (void)applyStyles {
  // self.layer.borderColor =
  //     [GADTTemplateView colorFromHexString:@"E0E0E0"].CGColor;
  // self.layer.borderWidth = 1.0f;
  [self.mediaView sizeToFit];
  if ([self styleForKey:GADTNativeTemplateStyleKeyCornerRadius]) {
    float roundedCornerRadius =
        ((NSNumber *)[self styleForKey:GADTNativeTemplateStyleKeyCornerRadius])
            .floatValue;

    // Rounded corners
    self.iconView.layer.cornerRadius = roundedCornerRadius;
    self.iconView.clipsToBounds = YES;
    ((UIButton *)self.callToActionView).layer.cornerRadius =
        roundedCornerRadius;
    ((UIButton *)self.callToActionView).clipsToBounds = YES;
  }
...

}

happy coding!