oss-fuzz icon indicating copy to clipboard operation
oss-fuzz copied to clipboard

infra: update jazzer args

Open manunio opened this issue 1 year ago • 5 comments

The command python infra/helper.py coverage pdf-js was failing with error Unknown Jazzer.js option 'coverageDirectory' or Unknown Jazzer.js option 'coverageReporters'. This pr updates coverage args as per jazzer.s docs which were introduced as breaking change in https://github.com/CodeIntelligenceTesting/jazzer.js/pull/429

manunio avatar Jan 21 '24 18:01 manunio

Another thing worth noting is that javascript projects are not appearing in the Coverage Builds section of https://oss-fuzz-build-logs.storage.googleapis.com/index.html.

manunio avatar Jan 21 '24 19:01 manunio

@jonathanmetzman ping :)

manunio avatar Feb 02 '24 11:02 manunio

Can you share the link where you saw this: Unknown Jazzer.js option 'coverageDirectory' or Unknown Jazzer.js option 'coverageReporters ?

jonathanmetzman avatar Feb 21 '24 16:02 jonathanmetzman

/gcbrun trial_build.py javascript --fuzzing-engines none --sanitizers none coverage

jonathanmetzman avatar Feb 21 '24 16:02 jonathanmetzman

Can you share the link where you saw this: Unknown Jazzer.js option 'coverageDirectory' or Unknown Jazzer.js option 'coverageReporters ?

It was the result of running following command:

python infra/helper.py build_image pdf-js
python infra/helper.py build_fuzzers --sanitizer coverage pdf-js
python infra/helper.py coverage pdf-js

Resulting in:

Error: Unknown Jazzer.js option 'coverageDirectory'
    at /out/pdf-js/node_modules/@jazzer.js/core/dist/options.js:167:23
    at Array.forEach (<anonymous>)
    at mergeOptions (/out/pdf-js/node_modules/@jazzer.js/core/dist/options.js:163:24)
    at /out/pdf-js/node_modules/@jazzer.js/core/dist/options.js:148:16
    at Array.reduce (<anonymous>)
    at buildOptions (/out/pdf-js/node_modules/@jazzer.js/core/dist/options.js:146:10)
    at Object.handler (/out/pdf-js/node_modules/@jazzer.js/core/dist/cli.js:223:64)
    at /out/pdf-js/node_modules/yargs/build/index.cjs:1:8993
    at j (/out/pdf-js/node_modules/yargs/build/index.cjs:1:4956)
    at _.handleValidationAndGetResult (/out/pdf-js/node_modules/yargs/build/index.cjs:1:8962)
jpeg_image.fuzz failed to produce coverage-final.json file.
coverage files in /out/dumps/fuzzers_coverage merged into /out/merged_coverage/coverage.json
Serving the report on http://127.0.0.1:8008/linux/index.html
Serving HTTP on 0.0.0.0 port 8008 (http://0.0.0.0:8008/) ...

Caused by following line: https://github.com/google/oss-fuzz/blob/f5f58c74402049c4df659d26a4126e59390a309c/infra/base-images/base-runner/coverage#L253

manunio avatar Feb 21 '24 16:02 manunio