ground-android

ground-android copied to clipboard

@rawbzz @vittorino FYI

@shobhitagarwal1612 Are you able to take one this issue?

I have a couple of tasks already ongoing. We can take this one up once the proto migration is done.

@anandwana001 can you please coordinate with @rfontanarosa, who is working on https://github.com/google/ground-platform/issues/1744?

You only need to show to pictured UI if more than one value is specified in DrawGeometry.allowed_methods.

@gino-m could you please help me with the figma access for this design? earlier password no more working

@anandwana001 did you get access to the figma? Anything else needed for this one?

@anandwana001 did you get access to the figma? Anything else needed for this one?

@anandwana001 Gentle ping!

@anandwana001 did you get access to the figma? Anything else needed for this one?

Sorry for the late response

Yes, got the figma access. Got all doubts cleared now. Thanks.

@anandwana001 We spoke. Let's try to implement this first, but eventually start creating tasks dynamically as they're needed rather than at the start of the data collection flow. Related to #2829 and likely other data collection issues. @shobhitagarwal1612 FYI

@rawbzz A few edge case questions:

• How does the user change the geometry type if they change their mind?
• What happens when they click "Close"? Are they transported to the previous task? What if this is the first task?
• In this design, the dialog appears before the user has seen the user-defined instructions for the task. They can see them behind the dialog, but this seems counterintuitive.
• We need to add back "capture location", as discussed https://github.com/google/ground-platform/issues/1744#issuecomment-2303565052

All of this considered, should we be showing this selector directly on the task screen somehow, eg in place of the map?

@amegantz Can we think of a better prompt than "How will you map this site?" Note we already show "Map a new site" above, so we could just remove the title all together and just show the buttons where the map is currently?

@rawbzz Looks great, thank you! Added a few variants to the Figma for your input when you have a sec 🙏

@rawbzz, thanks for your feedback on Figma. @anandwana001 Latest tweaked designs:

@gino-m IIUC, only "drop a pin" and "draw area" should be the valid task types for addLoiTask flow. Why do we have "Capture Location" in the above mock?

This feature was recently deproritized by @lecrabe and others in favor of creating two jobs with different geometry tasks.

The presence of Capture location here refers to a separate FR by @n-clinton to allow new Lois to be added using that task. @kenstershiro can you please file or link to that here?

Thanks for clarification. Clearing the assignee for now.

As discussed @lecrabe and others, this same capability can be approximated by adding two jobs with different geometry task types. Closing for now.