graphicsfuzz icon indicating copy to clipboard operation
graphicsfuzz copied to clipboard

AssertionError in makeUniformBindings on master branch

Open jonathanmetzman opened this issue 6 years ago • 3 comments

I get this crash pretty consistently: To repro:

$ java -ea -cp ~/graphicsfuzz-build/jar/tool-1.0.jar com.graphicsfuzz.generator.tool.GenerateShaderFamily ~/shaders-build/references/GLSL_300_es/nested_loops.json ~/shaders-build/donors /tmp/k --generate-uniform-bindings

11:42:10.430 INFO  ExecHelper - Result: 0
java.lang.AssertionError
        at com.graphicsfuzz.common.transformreduce.GlslShaderJob.makeUniformBindings(GlslShaderJob.java:119)
        at com.graphicsfuzz.generator.tool.PrepareReference.prepareReference(PrepareReference.java:142)
        at com.graphicsfuzz.generator.tool.PrepareReference.prepareReference(PrepareReference.java:116)
        at com.graphicsfuzz.generator.tool.GenerateShaderFamily.mainHelper(GenerateShaderFamily.java:160)
        at com.graphicsfuzz.generator.tool.GenerateShaderFamily.main(GenerateShaderFamily.java:375)

Let me know if you need the specific donors folder and reference files.

jonathanmetzman avatar Aug 23 '19 18:08 jonathanmetzman

Sorry, not sure if it happens on master. It's happening on dev. I think this bug is pretty much blocking spirv fuzzing. It seems to happen on 100% of executions.

jonathanmetzman avatar Sep 06 '19 02:09 jonathanmetzman

I think this bug is pretty much blocking spirv fuzzing. It seems to happen on 100% of executions.

It's not blocking anymore, I'll explain in our sync.

jonathanmetzman avatar Sep 06 '19 05:09 jonathanmetzman

// We cannot yet deal with adding bindings for uniform arrays. assert !variablesDeclaration.getDeclInfo(0).hasArrayInfo();

paulthomson avatar Sep 06 '19 15:09 paulthomson