gemma.cpp

gemma.cpp copied to clipboard

This also preserves the gemma binary as a build artefact should folks want to grab a pre-built binary.

Dropped the use of the lukka/cmake actions due to conflicts with --preset. This isn't that bad as we were mostly overriding the default behaviour anyway.

It also shaves ~2 min off the build since the GitHub builders already have CMake pre-installed.

[!IMPORTANT]
Currently the resulting Windows binary is being detected as Trojan:Win32/Phonzy.B!ml by Windows Defender ...and only Windows Defender. This is almost certainly a false positive given that the binary is built on GitHub's official "windows_latest" image with the provided CMake and Clang compilers. I've submitted the file to Microsoft Security Intelligence (Submission ID: f2092a44-4b58-45bb-b6ed-071d43a9bc2a) to ask that they investigate.

Also opened actions/runner-images#9403 to report the issue.

Latest build (8034688123) is ~~no longer being detected as a threat. 🤞~~ spoke too soon. 🤦

Looks good to me, thanks. Would you mind rebasing?

Looks good to me, thanks. Would you mind rebasing?

Unfortunately I can't. Copybarra wiped away the Windows build again: https://github.com/google/gemma.cpp/commit/696597383cabbd7e78c5e581e6425b452f267ab1

Bummer :/ We're working on it, seems caused by a copybara bug which we are told will be fixed soon.

Unfortunately I can't. Copybarra wiped away the Windows build again: 6965973

Sorry about that! Changes should have been restored in https://github.com/google/gemma.cpp/commit/4c155bd3df70e45837a50a3d7496733ba47e000f, and we've aligned on our workflows so reversions shouldn't happen again.

Let me try to run CI for this pull request now.

Our Copybara automation has effectively merged this pull request and imported it as a commit in dev branch: https://github.com/google/gemma.cpp/commit/7aeade5c9d026eece614503fd704dcfc5ad0d625.

Unfortunately, the automation doesn't actually merge pull requests right now, so we have to manually close it – we're looking into fixing this asap. Thanks for your contribution!

Hi @dan-zheng,

Sorry about that! Changes should have been restored in https://github.com/google/gemma.cpp/commit/4c155bd3df70e45837a50a3d7496733ba47e000f, and we've aligned on our workflows so reversions shouldn't happen again.

No worries. I know how much a pain syncing internal/external repositories can be.

Unfortunately, the automation doesn't actually merge pull requests right now, so we have to manually close it – we're looking into fixing this asap. Thanks for your contribution!

I rebased my branch onto the current dev branch which seems to have been enough for GitHub to realize the changes have been merged and automatically close the branch. Thanks for checking. 😄