fuzzbench icon indicating copy to clipboard operation
fuzzbench copied to clipboard

Move benchmark git checkout commands to Dockerfile, just after clone for readability

Open inferno-chromium opened this issue 5 years ago • 2 comments

inferno-chromium avatar Jul 30 '20 14:07 inferno-chromium

combine all clones in RUN and prune to save space

Is this really a big concern? We don't force this in OSS-Fuzz. i don't want to annoy integrators with making optimal dockerfiles.

jonathanmetzman avatar Jul 30 '20 17:07 jonathanmetzman

combine all clones in RUN and prune to save space

Is this really a big concern? We don't force this in OSS-Fuzz. i don't want to annoy integrators with making optimal dockerfiles.

I don't think it's important to prune, and definitely not something to enforce. Sorry, my comment could have been more specific: i was wondering if it'd make sense to keep the git clone and checkout commands next to each other, ie do the checkout in the Dockerfile too, eg:

RUN git clone <repo> <dir>
RUN git -C <dir> checkout <commit>

primarily for readability. I mentioned pruning as something we'd also have the option for if we did cloning and checkout together, in addition to readability.

lszekeres avatar Jul 30 '20 18:07 lszekeres