fuzzbench icon indicating copy to clipboard operation
fuzzbench copied to clipboard

Support non-alphanumeric passwords in alembic.

Open mvanotti opened this issue 2 years ago • 2 comments

This commit modifies alembic's env.py, so that it supports non-alphanumeric passwords.

The script creates an url to connect to the database, but the passworld was not url-escaped. Passwords with characters like @, : and . were causing failures.

The password is set as a config in sqlalchemy, which uses python's string interpolation. Now we replace instances of % with %% so that passwords that contain % can be used.

Fixes issue #1801

mvanotti avatar Apr 03 '23 16:04 mvanotti

This commit needs more work, I barely tested it.

mvanotti avatar Apr 03 '23 16:04 mvanotti

This commit needs more work, I barely tested it.

I see, I will convert it to a draft for now, but feel free to convert it back once you reckon it is ready. Thanks!

DonggeLiu avatar Apr 10 '23 23:04 DonggeLiu