fuzzbench icon indicating copy to clipboard operation
fuzzbench copied to clipboard

Fix service account key issues

Open jonathanmetzman opened this issue 4 years ago • 2 comments

Fuzzbench uses service account keys because when we didn't use them there was a horrible bug logging which is bad for 2 reasons:

  1. It breaks experiments because we log everywhere.
  2. It is really hard to debug when logging doesn't work.

We did this about a year ago. This solution is imperfect however. Because service account key creation happens on the dispatcher, if it fails, we have no feedback at all. It fails not that infrequently because there is a limit of 10 service account keys.

I can think of a few solutions/mitigations to this problem.

  1. Stop using service account keys. This solution is only viable if the above bug is fixed.
  2. Store service account key somewhere and share between experiments. The problem with this approach is Fuzzbench exposes a lot to users and there is nowhere really to hide this, we could create another bucket though. This approach will probably solve the limit issue.
  3. Make run_experiment.py pass service account key to the dispatcher. This has two advantages: 1. service account key validation can happen in run_experiment so we can get feedback 2. It allows us to avoid the limit on service account keys.

jonathanmetzman avatar Jan 12 '21 17:01 jonathanmetzman

This issue caused the failure in #1023

jonathanmetzman avatar Jan 12 '21 17:01 jonathanmetzman

FYI the serenity build fails and make build-coverage-serenity_fuzzbmploader locally fails as well.

jonathanmetzman avatar Jan 12 '21 18:01 jonathanmetzman