closure-compiler closure-compiler-unshaded v20240317 embeds jakarta.annotation-api

closure-compiler-unshaded v20240317 embeds jakarta.annotation-api

Open tmortagne opened this issue 1 year ago • 5 comments

It can cause some conflicts when you depend on both closure-compiler-unshaded and jakarta.annotation-api directly or through other dependencies.

I would have expected it to be a dependency, along with the others declared in the pom file.

Mar 26 '24 14:03 tmortagne

Thanks for pointing this out. We're unlikely to do anything about it immediately, but I expect we will fix it before doing another release.

Mar 28 '24 16:03 brad4d

Thanks @brad4d, that's definitely good enough for me 🙂

Mar 28 '24 17:03 tmortagne

@tmortagne Do you know if this has regressed in the latest release?

Mar 28 '24 20:03 gkdn

Yes, it appears this is a regression in the latest release:

https://repo1.maven.org/maven2/com/google/javascript/closure-compiler-unshaded/v20231112/closure-compiler-unshaded-v20231112.jar doesn't have these javax.annotation files, but
https://repo1.maven.org/maven2/com/google/javascript/closure-compiler-unshaded/v20240317/closure-compiler-unshaded-v20240317.jar does

Mar 28 '24 20:03 niloc132

Yes, as detailed by @niloc132 and as I should have mentioned a bit more explicitly in the issue description, it's indeed a regression from v20231112.

Mar 29 '24 07:03 tmortagne