amber

amber copied to clipboard

The function AmberTestInstance::iterate() allows only one of two states to be returned - Pass or Fail. Amber framework does check support of various device features, image format support etc. but if the device returns Not Supported the result is turned by Amber to Fail. I would advice to extend the Result class to store also Not Supported state.

How does the rest of CTS support this? Is it considered a failure, success or is there a third state we can set in CTS to log this?

Instead of changing the Result class, we should add a check into the Recipe (or somewhere) to verify that the script is fully supported before executing. Then we only call execute if the script is fully supported.

CTS has 3 possible return states - Pass, Fail or Not Supported. Before the test executes it queries the device to check if the formats, operations etc used by the test are supported. If not, it stops execution and returns Not Supported.

@dneto0