amber

amber copied to clipboard

Add a feature that will run a pipeline and report the amount of time that it took to run. Since the times will be relatively small, the pipeline should be run many times and the average time reported.

This will be useful for reporting and reproducing performance problems. It would also be a good tool for testing how small changes to a shader effect the performance of the shader.

Does --log-graphics-calls-time do part of what you want? Or is it to low level?

For a compute pipeline, the call to vkQueueSubmit is done asynchronously. It returns before the actual pipeline is run. The time for that call is not meaningful. If a call to vkQueueWaitIdle is done immediately afterward is could be, but it would include all of the overhead, and would miss a time before that call was made.

I would be looking for something that puts a vkCmdWriteTimestamp command before and after the vkCmdDispatch command in the command buffer. Then it can return the difference in the two times. This would isolate the time to actually run the pipeline.

Ok, so you're looking for something compute specific? I wonder if wrapping something similar for graphics would be useful for the graphicsfuzz folks @afd @paulthomson ?

I would like graphics and compute, I was just using compute as an example.

ClusterFuzz->GraphicsFuzz -- because I don't want to unfairly take credit for ClusterFuzz :-)

I don't think we have an immediate need for this, but it sounds like a good idea and could be useful at some point. We plan to manually REPEAT a "DRAW_RECT" and add commands to check that the framebuffer does not change, but we won't be measuring performance for now.