amber icon indicating copy to clipboard operation
amber copied to clipboard

Support choosing host device

Open mvainola opened this issue 6 years ago • 6 comments

Currently Amber picks the first VkPhysicalDevice that meets its feature and extension requirements. Setting VK_ICD_FILENAMES is sufficient in most cases but not when trying to choose between two devices using the same ICD.

My idea was to add two new command line options:

  • List physical Vulkan devices with IDs and exit
  • Specify Vulkan device ID to run with

mvainola avatar Aug 20 '19 08:08 mvainola

I'd skip the first one, if you can get the vulkan devices from the vulkan info command, yea? The second seems like it would be useful to add.

dj2 avatar Aug 20 '19 12:08 dj2

I'm fine with using vulkaninfo to get the IDs and just adding an option similar to --deqp-vk-device-id in the CTS.

mvainola avatar Aug 20 '19 13:08 mvainola

Let's go with something like -d for device. That way, hopefully, it can be used for Dawn as well. @sarahM0 is there a way in Dawn to specify the device to use?

dj2 avatar Aug 20 '19 13:08 dj2

@Kangz

sarahM0 avatar Aug 20 '19 16:08 sarahM0

Yep that's something we do in the dawn_end2end_tests already. See mVendorIDFilter and friend here that use dawn_native::Adapter::GetPCIInfo to get information to do the filtering.

Kangz avatar Aug 20 '19 16:08 Kangz

Hm, didn't mean to close, #698 does the Vulkan side, still need Dawn support

dj2 avatar Oct 28 '19 17:10 dj2