amber icon indicating copy to clipboard operation
amber copied to clipboard

Specify shader as an external file

Open alan-baker opened this issue 6 years ago • 3 comments

It would be nice to point to another file when specifying the shader in Amber. I find it useful when handwriting SPIR-V to have direct access to the shader separate from the script.

Nice to have, but not essential.

alan-baker avatar Jan 14 '19 21:01 alan-baker

This one I'm on the fence about, I can see how this would make creating the script easier, but I'm not sure if it's generally a direction we want to go.

I wonder if there is a way we can fix the error messages coming out of spriv-val to point to the modified line numbers ....

dj2 avatar Jan 15 '19 03:01 dj2

This is an old issue, so sorry if its somewhere else, but why would this not be a direction to go towards? Im ignorant here.

Its not huge issue to go around (can use python and have the effective same thing in no time), and im sure theres other stuff to work on, but am curious of reasoning to not implement it beyond that?

JordanHendl avatar Jun 16 '23 21:06 JordanHendl

The idea is that an amber script is a fully self contained bug/test representation. You have a single file which contains everything needed to reproduce. Once you allow external files you now have to deal with sending around multiple files, having them in the right place in the filesystem, lookup rules, etc.

So, I can understand why it's useful, but I'm not convinced it fits within what amber does.

dj2 avatar Jun 16 '23 23:06 dj2