amber

amber copied to clipboard

For certain cases device properties need to be checked same way as device features. For example VK_KHR_shader_float_controls extension have a set of fields (DenormPreserve) that are available in VkPhysicalDeviceFloatControlsProperties. Amber does not allow these to be checked and also does not have appropriate syntax for checking properties. This pull request adds both.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I don't get it: I don't have google account. What should I do?

I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA.

I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA.

Thank you for quick reply.

I skim briefly through the page and find nothing more useful.

I scrolled down and click "Manage your agreements" at bottom and ... alas "Please login to google."

Any other thoughts?

Yea, turns out I was wrong, from the FAQ on that page A Google account is required to sign the CLA. As far as I can see, there is no way to sign the CLA without one, and without a signed CLA we are unable to accept the PR.

The code looks good to me. Once the CLA is sorted out I think this is good to go.

kokoro:run

kokoro:run

Something has gone strange with the bots and they're failing to compile in, it looks like, swiftshader? I'm going to put up a CL and see if I can figure out what's gone wrong.

I'm still working on the bots. Needs to have dependencies updated but getting all of them to the right versions is proving difficult. https://github.com/google/amber/pull/1037 is my work in progress CL, but that needs a change to SwiftShader so it can work with a newer SPIRV-Tools.

Ok, if you can rebase this on top of main, I fixed up the various bot issues and got a green build and landed it.

kokoro:run