mediapipe icon indicating copy to clipboard operation
mediapipe copied to clipboard

Hello World BUILD should not require internal deps

Open cgtinker opened this issue 3 years ago • 0 comments

Please make sure that this is a build/installation issue and also refer to the troubleshooting documentation before raising any issues.

System information (Please provide as much relevant information as possible)

  • Linux Manjaro

Describe the problem: Running the hello_world BUILD from a another local repository results in visibility issues. This took me quiet a while to figure out as a hello_world example usually should be easy to run.

Provide the exact sequence of commands / steps that you executed before running into the problem:

  • Create a new repository
  • Configure the workspace (containing mediapipe deps)
  • Use mediapipe as local repository
  • Run the hello_world example

Solution: Change the hello_world dependencies from:

cc_binary(
    name = "hello_world",
    srcs = ["hello_world.cc"],
    visibility = ["//visibility:public"],
    deps = [
        "//mediapipe/calculators/core:pass_through_calculator",
        
        "//mediapipe/framework:calculator_graph",
        "//mediapipe/framework/port:logging",
        "//mediapipe/framework/port:parse_text_proto",
        "//mediapipe/framework/port:status",
    ],
)

To:

cc_binary(
    name = "hello_world",
    srcs = ["hello_world.cc"],

    deps = [
        "//mediapipe/calculators/core:pass_through_calculator",
        "//mediapipe/framework:calculator_framework",
        "//mediapipe/framework/port:logging",
        "//mediapipe/framework/port:parse_text_proto",
        "//mediapipe/framework/port:status",
    ],
)

cgtinker avatar Jul 26 '22 09:07 cgtinker