nestjs icon indicating copy to clipboard operation
nestjs copied to clipboard

Published 20 hours ago • verified publisher icon golevelup

Stripe v15

Open matheo opened this issue 1 year ago • 2 comments

Hi @WonderPanda! First, thanks for the great NestJS stuff! I wonder how difficult would be to upgrade to Stripe v15 with the changes of the pinned API version to 2024-04-10.

I want to help with the jump so I wonder if previous upgrades thrown some type errors to fix and that's it? or it needs deeper checks in the API Upgrade Guide?

Thanks in advance!

matheo avatar Jun 12 '24 15:06 matheo

I haven't been keeping up to date with what's new in the Stripe API so I think it would be awesome if someone could review the upgrade guides and do some local testing to make sure its all working

WonderPanda avatar Jun 12 '24 16:06 WonderPanda

this definitely needs some work - was trying it today with no luck in terms of making it work. was using a self-made solution prior to this.

armfuldev avatar Jun 22 '24 13:06 armfuldev

Any updates on this? There's v16 now.

vinialbano avatar Sep 11 '24 13:09 vinialbano

If anyone can help by contributing to the update of Stripe to v15/v16 I'll be happy to review (unfortunately I haven't used the Stripe lib for awhile and don't have proper context).

underfisk avatar Sep 26 '24 12:09 underfisk

If @WonderPanda can release a major version, stripe v16 should be included in the next major release. https://github.com/golevelup/nestjs/pull/796

I have tested it, works fine but I don't have any "good" setup to replicate it. If any issue is encountered I will collect that piece of feedback and eventually add e2e tests to help preventing regressions

underfisk avatar Sep 30 '24 11:09 underfisk