appengine icon indicating copy to clipboard operation
appengine copied to clipboard

Adopt google.golang.org/protobuf

Open tlimoncelli opened this issue 4 years ago • 12 comments

This project imports github.com/golang/protobuf which is obsolete. Are there plans to switch to google.golang.org/protobuf ?

tlimoncelli avatar Dec 03 '20 18:12 tlimoncelli

i have problem with the same import, my organization uses a dependency vulnerability check and give me some issues. Captura de Pantalla 2021-03-30 a la(s) 19 25 07

firenessmax avatar Mar 30 '21 22:03 firenessmax

We should reopen and address this in some way

Deleplace avatar May 10 '23 21:05 Deleplace

https://github.com/golang/appengine/releases/tag/v2.0.4 includes https://github.com/golang/appengine/pull/314, which should have this fixed. Haven't verified it yet.

jinglundong avatar Jul 11 '23 21:07 jinglundong

Any progress on this issue?

aimuz avatar Aug 18 '23 06:08 aimuz

https://github.com/golang/appengine/releases/tag/v2.0.4 should have this fixed. Could you share more details in case I missed anything?

jinglundong avatar Aug 19 '23 01:08 jinglundong

Ideally you should switch github.com/golang/protobuf to google.golang.org/protobuf

There is also code that is relying on this library github.com/golang/protobuf

https://github.com/golang/appengine/blob/a080531dcab843de8cd8a4156b7fa1e14ebd68da/user/user.go#L12

https://github.com/golang/appengine/blob/a080531dcab843de8cd8a4156b7fa1e14ebd68da/mail/mail.go#L27

aimuz avatar Aug 21 '23 01:08 aimuz

ACK. I will try to share an update early next week. Sorry for not being able to stay on top of this issue.

jinglundong avatar Aug 25 '23 01:08 jinglundong

@jinglundong do you have an update? Since the oauth2 package depends on appengine, the import of the deprecated package is spread across the half go universe (https://github.com/golang/oauth2/blob/master/go.mod)

jkroepke avatar Nov 20 '23 05:11 jkroepke

image

Can we get some update on when we can expect not to download & compile 2 versions of the same thing?

trakhimenok avatar Nov 24 '23 19:11 trakhimenok

Is anyone assigned to this?

trakhimenok avatar Apr 17 '24 08:04 trakhimenok