migrate

migrate copied to clipboard

Describe the Bug fails to compile for *bsd variants.

Steps to Reproduce try to cross compile with sqlite for netbsd, freebsd or openbsd

❯ env GOOS=freebsd go build ./...

fails with:

package github.com/golang-migrate/migrate/v4/database/sqlite
	imports modernc.org/sqlite
	imports modernc.org/libc
	imports modernc.org/libc/errno: build constraints exclude all Go files in /Users/jimlambrt/go/pkg/mod/modernc.org/[email protected]/errno
package github.com/golang-migrate/migrate/v4/database/sqlite
	imports modernc.org/sqlite
	imports modernc.org/libc
	imports modernc.org/libc/signal: build constraints exclude all Go files in /Users/jimlambrt/go/pkg/mod/modernc.org/[email protected]/signal
package github.com/golang-migrate/migrate/v4/database/sqlite
	imports modernc.org/sqlite
	imports modernc.org/libc/sys/types: build constraints exclude all Go files in /Users/jimlambrt/go/pkg/mod/modernc.org/[email protected]/sys/types
package github.com/golang-migrate/migrate/v4/database/sqlite
	imports modernc.org/sqlite
	imports modernc.org/libc
	imports modernc.org/libc/time: build constraints exclude all Go files in /Users/jimlambrt/go/pkg/mod/modernc.org/[email protected]/time
package github.com/golang-migrate/migrate/v4/database/sqlite
	imports modernc.org/sqlite
	imports modernc.org/libc
	imports modern
c.org/libc/unistd: build constraints exclude all Go files in /Users/jimlambrt/go/pkg/mod/modernc.org/[email protected]/unistd

Expected Behavior Shouldn't fail to cross compile on bsd variants when using sqlite

I can confirm the same results for various combinations of *bsd and some common arch, ie:

• GOOS=freebsd GOARCH=amd64
• GOOS=freebsd GOARCH=arm64
• GOOS=openbs GOARCH=amd64
• GOOS=openbs GOARCH=arm64

These all build for v4.14.1 but not for v4.15.0

My guess is that there's an issue with modernc.org/sqlite See: https://pkg.go.dev/modernc.org/sqlite#hdr-Supported_platforms_and_architectures

If modernc.org/sqlite can we revert: https://github.com/golang-migrate/migrate/pull/555 since it would seem this is a fairly large breaking change?