Galen O’Hanlon

Results 21 comments of Galen O’Hanlon

Setting the `displayScale` trait appropriately isn't enough to make the currently running device runtime produce view snapshots that match some other device runtime — it merely makes the rendered image...

More alternatives, same as the proposed in this PR but removing the emphatic/redundant "exact": > ⚠️ Warning: Snapshots must be compared using the same simulator that originally took the reference...

FYI: There's a promising open PR (#571) that aims to address three issues involving that loop, including its surprisingly long execution time (when compiled without optimizations, as is default for...

Unfortunately, the only way to capture a true "iPhone X" rendering is to run your test suite with that device simulator. The `as: .image(on: .iPhoneX)` sets up the dimensions and...

I just noticed your questions, which I think I mostly answered above, but I'll answer directly: > If my image takes iphoneX and I if the test runs on iphone...

I'm not running snapshot testing on CI, but it can certainly be done, including with git-lfs. How's it failing, exactly? Are you using Github Actions, or something else? Keep in...

> We use Jenkins so I think we will need to add some extra steps for enabling it to be able to fetch from lfs right? Yes. You may just...

I will commit the `.python-version` file, too, as is a common practice in the Ruby community. The `.ruby-version` file isn't only used by rbenv, either. For example, it's respected by...

Have you tried overriding the method [`prefersStatusBarHidden`](https://developer.apple.com/documentation/uikit/uiviewcontroller/1621440-prefersstatusbarhidden) from `UIViewController` to return `false`? If you‘re playing with the included example app, you can make this change in `ImageCollectionViewController`, i.e.: ``` Swift...

_Disclaimer: I've used Nginx in front of Ruby app servers for years (Unicorn mostly), but just started using it on Heroku a couple days ago. I myself am very new...