godot

godot copied to clipboard

In the case of a preload()ed Resource that will be later used for a @export var typed_array : Array[MyRes] identifier is nullptr which leads to a quick death by a segfault when trying to set the hint. Looking at the to_string() method it seems for a very long time we assumed that this might be the case, but we don't do it know.

Other explanation is that when set_container_element_type() is called a non-fully initialized DataType for a class is passed, for some reason.

CC @rune-scape

Looks good! Could you squash the commits? See PR workflow for instructions.

I wanted to ask it, to be honest, but sure ;).

On Wed, 30 Nov 2022 at 08:13, Rémi Verschelde @.***> wrote:

Looks good! Could you squash the commits? See PR workflow https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase for instructions.

— Reply to this email directly, view it on GitHub https://github.com/godotengine/godot/pull/69269#issuecomment-1331731216, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNME2BJHDDZFDPOOASYHN3WK35AHANCNFSM6AAAAAASMXEKPM . You are receiving this because you authored the thread.Message ID: @.***>

Thanks! And congrats for your first merged Godot contribution :tada:

Not the last one I guess ;).

On Wed, 30 Nov 2022 at 10:53, Rémi Verschelde @.***> wrote:

Thanks! And congrats for your first merged Godot contribution 🎉

— Reply to this email directly, view it on GitHub https://github.com/godotengine/godot/pull/69269#issuecomment-1331895907, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNME2B57QRDOKD6XZW7NODWK4PZJANCNFSM6AAAAAASMXEKPM . You are receiving this because you authored the thread.Message ID: @.***>