godot icon indicating copy to clipboard operation
godot copied to clipboard

Node with editable children activated do not save their state in the tree.

Open Torguen opened this issue 2 years ago • 13 comments

Godot version

v3.5.1.rc1.official [293c3844b] v3.5.2.rc2.official [1a2bf3eb4]

System information

w10 64

Issue description

When you collapse/expand a node changes are made but the scene does not indicate that it should be saved, the scene does not show the asterisk next to its name. If you do not save the scene manually, the node will not save its expanded/collapsed state.

The error does not occur if you make any changes to the node and the scene needs to be saved or you save the scene even though the scene indicates that it does not require saving its state.

Follow these steps so you don't make the mistake and the node saves collapsed. Collapse the node. Change the name of the node. Save the scene. Now the node will appear collapsed but that doesn't fix the problem.

Conclusion: The node does not save its collapsed/expanded state when closing the scene. You must manually save for the expanded/collapsed node state to be saved. The node only saves its collapsed/expanded state if it makes any changes that require the scene to be saved or you save the scene even though there are no changes to save.. Otherwise, the node does not save its collapsed/expanded state.

Steps to reproduce

Create a node and add childrens. The node expands showing its children. Collapse the node. Save the project. Load the project again. Check that the state of the node is not saved and is shown expanded again.

The node will only save its expanded/collapsed state if you make changes to the scene that require saving the scene or you save the scene even though the scene indicates that it does not require saving its state.

Minimal reproduction project

No specific project is needed, just a node that can be collapsed and expanded and do what I said above. testProblemaNodosExpandibles.zip

Torguen avatar Nov 12 '22 09:11 Torguen

Please upload your video on Github directly, as it helps against link rot. (you just have to drag your video file inside the Markdown editor of your issue)

adamscott avatar Nov 12 '22 16:11 adamscott

Could not reproduce on 3.5.1, neither on 4.0 (master) Please test on the latest versions of Godot before creating an issue.

adamscott avatar Nov 12 '22 16:11 adamscott

The link works. Github has a 10 meg file limit, I tried to upload my file and it exceeded that limit.

I can't reproduce it in an example project either but it happens in my project.

I can send the project by private.

I haven't read any rules that require testing for problems in the latest versions of Godot.

Torguen avatar Nov 13 '22 12:11 Torguen

I haven't read any rules that require testing for problems in the latest versions of Godot.

Because the issue becomes obsolete if it was fixed on a newer release and the ticket will be closed.

adamscott avatar Nov 13 '22 14:11 adamscott

I only use official published versions, the latest official published version is: v3.5.1.rc1.official [293c3844b]

Maybe it's not fixed, you can't reproduce it because it only happens in projects like mine, which meet some condition that causes the error.

Maybe you tried to reproduce it in a small project and, as I said before, in a small project it doesn't happen.

Torguen avatar Nov 13 '22 14:11 Torguen

I only use official published versions, the latest official published version is: v3.5.1.rc1.official [293c384]

No. The latest published version is 3.5.1

Screenshot_20221113-100544

adamscott avatar Nov 13 '22 15:11 adamscott

Ok, I missed that version!

Also the problem is different, now the node will always appear collapsed even if you expand it, it will not keep its state and it will appear collapsed.

I guess the issue is that nodes don't save their "expanded/collapsed" state when a project is opened/closed.

Torguen avatar Nov 13 '22 15:11 Torguen

I'm not sure if there is anything actionable left here.

If the problem is only in a 3.5.1 release candidate but is fixed in 3.5.1 then can we go ahead and close this bug report?

clayjohn avatar Nov 17 '22 07:11 clayjohn

The problem is that nodes (that's what happens with nodes that inherit from another node, as described at the beginning) don't save their "expand/collapse" state to the tree when the project is closed. v3.5.1.stable.official [6fed1ffa3]

Torguen avatar Nov 17 '22 08:11 Torguen

Please join a MRP. If it's not reproducible easily, the problem is maybe something else.

adamscott avatar Nov 17 '22 09:11 adamscott

This keeps happening in v3.5.2.rc2.official [1a2bf3eb4]

Watch the video:

https://user-images.githubusercontent.com/19652075/222676493-26973a4e-6abf-4b4b-8a80-520154eaf6f5.mp4

Torguen avatar Mar 03 '23 08:03 Torguen

Everything is clarified in the initial report.

Torguen avatar Mar 03 '23 09:03 Torguen

I don't understand why you need a test, this happens in all operating systems, it's something related to Godot's scene save system.

Torguen avatar Mar 07 '23 11:03 Torguen