primer icon indicating copy to clipboard operation
primer copied to clipboard

Re-enable the default layout option in the customizer

Open EvanHerman opened this issue 8 years ago • 2 comments

Resolves #226

This PR re-enables the default template selection inside of the customizer. This was removed in a previous PR, but without this option users are unable to update the default template option without using a filter.

Additionally, in a recent commit to wp-dev-lib phpcs.xml.dist is now supported and triggers PHPCS in our build process, which is throwing a few errors: https://travis-ci.org/godaddy/wp-primer-theme/builds/259868092

Customizer: Example

EvanHerman avatar Aug 01 '17 17:08 EvanHerman

@EvanHerman I'd like for us to think about how to improve the UX before re-introducing this. We need to help users understand that this is a "global" setting and that the live preview may have no effect if the page has a "Custom" layout selected.

I'm spit-balling here, but here is what I imagined. However, we can't put English words in images so we'd likely have to really build the metabox example haha.

Thoughts?

screenshot 2017-08-04 09 44 15 screenshot 2017-08-04 09 43 48

frankiejarrett avatar Aug 04 '17 14:08 frankiejarrett

Still not merged, I would love seeing this in production again 👍 What is the preferred way to add

add_filter( 'primer_default_layout', function () {
	return 'one-column-wide';
} );

currently? Where?

Commifreak avatar Oct 16 '20 17:10 Commifreak

Closing issues and PRs in preparation for repository archival

aledesma-godaddy avatar Mar 13 '23 19:03 aledesma-godaddy