www.go.cd icon indicating copy to clipboard operation
www.go.cd copied to clipboard

[Don't merge yet] Add release dates in release notes

Open arvindsv opened this issue 6 years ago • 6 comments

Looks like this:

2019_04_24_19-44-37

Fixes #963

/cc @varshavaradarajan

Dates from: https://github.com/gocd/gocd/releases

arvindsv avatar Apr 24 '19 23:04 arvindsv

@varshavaradarajan said it should be done on the downloads page too. Using the date from releases.json. That makes sense. Will do that tomorrow. Don't merge.

arvindsv avatar Apr 25 '19 00:04 arvindsv

Ping! pls see if this is still relevant.

kritika-singh3 avatar Dec 04 '20 05:12 kritika-singh3

@kritika-singh3 - I think this can be closed. We added the release date to the downloads page.

varshavaradarajan avatar Dec 04 '20 05:12 varshavaradarajan

@varshavaradarajan I think the PR was to add the release dates on the release notes. Is it not required anymore?

kritika-singh3 avatar Dec 04 '20 05:12 kritika-singh3

Nope. The downloads page makes a call and retrieves the releases.json. Which has the release date, so there is no manual step required. Here, when one edits the release notes, they need to remember and put that in. So, it's overkill. When the release date is already available on the downloads page.

I don't think @arvindsv will do that anymore. :P

varshavaradarajan avatar Dec 04 '20 06:12 varshavaradarajan

@varshavaradarajan hmm. Agree with your logic. I'll leave the decision to @arvindsv :)

kritika-singh3 avatar Dec 04 '20 06:12 kritika-singh3