bigquery-emulator icon indicating copy to clipboard operation
bigquery-emulator copied to clipboard
verified publisher icon goccy

Fix status code for duplicate job and datasets

Open thuibr opened this issue 2 years ago • 2 comments

thuibr avatar Dec 13 '23 22:12 thuibr

@goccy this is to replace #184. I tried to address your comments, but I don't think I can use errResponse. I'm copying what's done for duplicate tables instead.

thuibr avatar Dec 13 '23 22:12 thuibr

For some reason, even after making ErrDuplicatedDataset, it's still being reported as an internalError, and this equality check is returning false:

https://github.com/goccy/bigquery-emulator/pull/257/files#diff-4dacc7a06791d88085bc744a0a2aa16559cb5b9b8fddd705177bfa2fbfe41d29R683

thuibr avatar Dec 13 '23 23:12 thuibr