FFXIVQuickLauncher icon indicating copy to clipboard operation
FFXIVQuickLauncher copied to clipboard

refactor: abstract out Launcher > ILauncher/SqexLauncher

Open avafloww opened this issue 3 years ago • 3 comments

... and adds barebones ActozLauncher / ShandaLauncher for future use (or not).

This refactor helps to prepare XL for the possibility of supporting logins and patching for KR/CN FFXIV, although there would be a lot more work/complexity there (especially around Dalamud and the different game versions). In reality, it's mainly to be able to track KR/CN game versions in Thaliak, though of course I'd love to try to clean things up and upstream these changes.

avafloww avatar May 12 '22 05:05 avafloww

Would it be more reasonable to abstract out the Steam Launcher into its own class?

Especially considering there are three different platforms for the international version of FFXIV and a bool is a bit awkward to deal with that… (Something like a SquexLauncher base class maybe?)

marzent avatar May 12 '22 06:05 marzent

@marzent Yeah, I think that makes sense for dealing with the weirdness of Steam, good call! I'll do that.

avafloww avatar May 12 '22 06:05 avafloww

Hi, I think this pull will be a great help for what we're doing in XIVLauncherCN, and we'll be grateful if it can be merged to our upstream soon!

Bluefissure avatar May 27 '22 15:05 Bluefissure